chore: Cleanup repo #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
half-shell
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Hey @mpaulmier, thank you for tackling this issue 👍
Everything looks great to me.
However, something I think would be worth adding is the bump in the expected elixir version (in the mix.exs file).
Since the workflows only test for elixir 1.13 and elixir 1.15, we should probably start decommissioning any versions below that. I think it qualifies as on of the objectives of this cleanup.
We'll end up creating a new release in order to support that, probably a v2.4.0.
Would you mind writing and submitting that changes as well ?
|
LGTM 👍 You might want to sync with @Shakadak to get this merged and published, otherwise I'll merge it in a month. Thanks again ! |
half-shell
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #41
Remaining warnings are from dependencies, Poison and dializer which we may want to upgrade along with the elixir version at some point.
Tested with elixir 1.13.4 OTP 23